Handle null lanes in primitive take#8505
Merged
Merged
Conversation
Avoid dereferencing physical index values from null take lanes by zeroing those lanes before the cast/gather and intersecting the original index validity back into the result validity. Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
approved these changes
Jun 19, 2026
Merging this PR will degrade performance by 11%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | decompress_rd[f64, (10000, 0.01)] |
108.7 µs | 139.1 µs | -21.89% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.1)] |
109 µs | 139.5 µs | -21.85% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.0)] |
108.7 µs | 139.1 µs | -21.83% |
| ❌ | Simulation | decompress_rd[f32, (100000, 0.0)] |
496 µs | 583.8 µs | -15.05% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.1)] |
78.1 µs | 91.2 µs | -14.43% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.01)] |
78.1 µs | 91 µs | -14.2% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.0)] |
78.5 µs | 91.2 µs | -13.91% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
206.8 µs | 170.2 µs | +21.46% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
307.1 µs | 272.8 µs | +12.59% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/primitive-take-null-indices (c313c1f) with develop (35e4d72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid dereferencing physical index values from null take lanes by zeroing those lanes before the cast/gather and intersecting the original index validity back into the result validity.